Closed
Bug 738233
Opened 12 years ago
Closed 12 years ago
Fix test for bug 329212
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 14
People
(Reporter: Kwan, Assigned: Kwan)
References
Details
Attachments
(1 file)
|
2.95 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
Work in bug 737792 showed up some errors in the test file browser_bug329212.js with misplaced brackets causing the error message to be inside the expression and thus not show up.
|
Assignee | |
Comment 1•12 years ago
|
||
This fixes the errors in the test, moving misplaced brakets so the error message is an argument for ok() and not the function in the expression. Also changed an ok(foo != bar) to isnot(foo, bar).
|
||
Updated•12 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
||
Comment 2•12 years ago
|
||
Comment on attachment 608316 [details] [diff] [review] Fix errors in the test Thanks!
Attachment #608316 -
Flags: review+
|
|
||
Updated•12 years ago
|
Assignee: nobody → moz-ian
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 608316 [details] [diff] [review] Fix errors in the test Hmm, bzexport didn't update the patch description, so whoever checks it in will have to add the bug number & description.
|
|
||
Comment 4•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/8889d78513a7
Keywords: checkin-needed
Target Milestone: --- → Firefox 14
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8889d78513a7
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•