738410 - [bedrock] fix formatting of download buttons for unsupported platforms

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[James Long (:jlongster)]

Need to make sure download buttons work for people with javascript disabled or something from an unsupported platform.

See https://github.com/mozilla/bedrock/issues/31 for background.

Comment 1

[James Long (:jlongster)]

sgarrity wrote in the github issue:

"I've got this under way over in my fork (b861826). I'm wondering how to deal with the no-JS situation.

We've got a NOSCRIPT tag, that outputs the same thing as the .unsupported-download block, but by default, we show the .windows version of the download button. So, right now, without JS enabled, you see the unsupported AND Windows downloads, which doesn't usually fit, and looks odd. Any suggestions?"

Comment 2

[James Long (:jlongster)]

(In reply to James Long (:jlongster) from comment #1)
> sgarrity wrote in the github issue:
> 
> "I've got this under way over in my fork (b861826). I'm wondering how to
> deal with the no-JS situation.
> 
> We've got a NOSCRIPT tag, that outputs the same thing as the
> .unsupported-download block, but by default, we show the .windows version of
> the download button. So, right now, without JS enabled, you see the
> unsupported AND Windows downloads, which doesn't usually fit, and looks odd.
> Any suggestions?"

That's a good point, since we can now show a default thing we don't need the noscript stuff anymore. It still might be useful for the platform images (to avoid download more than needed) but here I think we can just remove it.

Comment 3

[James Long (:jlongster)]

Oh, but it shows the Windows button too. If we want the default to be the "unsupported" button we can make it that an then use js to show a button, like it did before. I can work on this.

Comment 4

[Kohei Yoshino [:kohei]]

I think this has been fixed at some point.

* if JavaScript is disabled: users will see 4 download buttons (Windows, Mac, Linux and Android).
* on unsupported platforms: users will see the following message:

> Your system doesn't meet the requirements to run Firefox.