Closed
Bug 738451
Opened 12 years ago
Closed 12 years ago
Permanent orange for release builds TB 12 & later: TEST-UNEXPECTED-FAIL | test-eml-subject.js
Categories
(Thunderbird :: Testing Infrastructure, defect)
Thunderbird
Testing Infrastructure
Tracking
(thunderbird12+ fixed, thunderbird13+ fixed)
RESOLVED
FIXED
Thunderbird 14.0
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Keywords: regression)
Attachments
(1 file)
772 bytes,
patch
|
mconley
:
review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Test Failure: a != b: 'Mozilla Thunderbird' != 'Thunderbird'. TEST-UNEXPECTED-FAIL | e:\buildbot\win32-unittest-mozmill-beta\build\mozmill\message-window\test-eml-subject.js | test-eml-subject.js::test_eml_empty_subject TEST-START | e:\buildbot\win32-unittest-mozmill-beta\build\mozmill\message-window\test-eml-subject.js | test_eml_normal_subject Test Failure: a != b: 'An email - Mozilla Thunderbird' != 'An email - Thunderbird'. TEST-UNEXPECTED-FAIL | e:\buildbot\win32-unittest-mozmill-beta\build\mozmill\message-window\test-eml-subject.js | test-eml-subject.js::test_eml_normal_subject The issue here is that in messenger.xul, we're using titledefault.label which equates to brandFullName, however the unit test is getting brandShortName. This is fine for the non-official builds, but breaks when we get around to the official ones. The fix is simple - use the right string :-)
Attachment #608458 -
Flags: review?(mconley)
Comment 1•12 years ago
|
||
Comment on attachment 608458 [details] [diff] [review] The fix Good catch!
Attachment #608458 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 2•12 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/daa0da7a8ea1
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 608458 [details] [diff] [review] The fix [Triage Comment] Taking this onto branches so that we don't hit it for more releases, especially as this is a test-only change.
Attachment #608458 -
Flags: approval-comm-beta+
Attachment #608458 -
Flags: approval-comm-aurora+
Assignee | ||
Comment 4•12 years ago
|
||
Checked in: http://hg.mozilla.org/releases/comm-aurora/rev/890343a19768 http://hg.mozilla.org/releases/comm-beta/rev/ad8f79a72aa2
status-thunderbird12:
--- → fixed
status-thunderbird13:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•