739115 - Port wifi and netutils code to ICS interfaces

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Helpfully, the libnetutils interface changed in ICS.  Also, the wpa_supplicant states changed in a non-backwards compatible way.  We need to handle these changes.

philikon, I see that the RIL code has its own import of netutils.  We'll need the netutils fixes there.  Or better, let's share a netutils.  Maybe your network manager patch does that.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Add runtime checks for ICS and select libnetutils interface and wpa_supplicant states appropriately

There's some duplicated code in here, but I don't know how to share it without even worse hackery.

This stuff needs to be refactored along with RIL.

Comment 2

[Andreas Gal :gal]

Comment on attachment 609186 [details] [diff] [review]
Add runtime checks for ICS and select libnetutils interface and wpa_supplicant states appropriately

Review of attachment 609186 [details] [diff] [review]:
-----------------------------------------------------------------

Land it. -15 karma for duplicating that code there. I am sure Blake will clean it up for you.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/mozilla-central/rev/7f87b434f7c6

Comment 5

[Philipp von Weitershausen [:philikon]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #0)
> philikon, I see that the RIL code has its own import of netutils.  We'll
> need the netutils fixes there.  Or better, let's share a netutils.  Maybe
> your network manager patch does that.

Correct. See bug 738063 which I didn't get to land before I went away for a few days last week. I'll rebase.