Closed
Bug 739193
Opened 12 years ago
Closed 12 years ago
nsTextEquivUtils::AppendTextEquivFromContent shouldn't use GetAccService()->GetAccessible
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: surkov, Assigned: maxli)
References
Details
(Whiteboard: [good first bug][mentor=hub@mozilla.com][lang=c++])
Attachments
(1 file, 1 obsolete file)
1.66 KB,
patch
|
hub
:
review+
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
Do gInitiatorAcc->Document()->GetAccessible(aContent) instead (http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsTextEquivUtils.cpp#139) We never cross document boundaries in name calculation handled in nsTextEquivUtils so we can do that.
Assignee | ||
Comment 1•12 years ago
|
||
All mochitests pass; it compiles fine. I don't know if there's any other way for me to verify I made the right change...
Attachment #610849 -
Flags: review?(hub)
Comment 2•12 years ago
|
||
you've removed the only meaningful use of shell so while your here you could stop getting the presShell all together.
Comment 3•12 years ago
|
||
Comment on attachment 610849 [details] [diff] [review] patch v1 Review of attachment 610849 [details] [diff] [review]: ----------------------------------------------------------------- ::: accessible/src/base/nsTextEquivUtils.cpp @@ +135,5 @@ > bool goThroughDOMSubtree = true; > > if (isVisible) { > nsAccessible* accessible = > + gInitiatorAcc->Document()->GetAccessible(aContent); As Trevor said, please remove nsIPresShell line 121 since we don't use it anymore.
Attachment #610849 -
Flags: review?(hub) → review-
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #610849 -
Attachment is obsolete: true
Attachment #611095 -
Flags: review?(hub)
Comment 5•12 years ago
|
||
Comment on attachment 611095 [details] [diff] [review] Patch v2 looks good thanks!
Attachment #611095 -
Flags: review+
Comment 6•12 years ago
|
||
Comment on attachment 611095 [details] [diff] [review] Patch v2 Review of attachment 611095 [details] [diff] [review]: ----------------------------------------------------------------- looks good
Attachment #611095 -
Flags: review?(hub) → review+
Reporter | ||
Updated•12 years ago
|
Assignee: nobody → maxli
Reporter | ||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8869f7a21a63
Target Milestone: --- → mozilla14
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8869f7a21a63
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•