739510 - Speed up construction of char * properties

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

This eliminates two additional copies: NS_ConvertASCIItoUTF16 and PromiseFlatString by constructing the JSString directly. It is also designed
so that literal strings will have their strlen computed at compile time.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Speed up DefineProperty for const char *

Comment 2

[(no longer active)]

Comment on attachment 609594 [details] [diff] [review]
Speed up DefineProperty for const char *

Review of attachment 609594 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/JSObjectBuilder.h
@@ +93,5 @@
> +    if (!string)
> +      mOk = JS_FALSE;
> +
> +    if (!mOk)
> +      return;

if (!string) {
  mOk = JS_FALSE;
  return;
}

Comment 3

[Jeff Muizelaar [:jrmuizel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5130ac1fa079

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/5130ac1fa079

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #0)
> It is also designed
> so that literal strings will have their strlen computed at compile time.

How so?