Closed Bug 739840 Opened 12 years ago Closed 12 years ago

Make nsDOMEventTarget subclasses inherit from nsDOMEventTargetHelper first

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla14

People

(Reporter: khuey, Assigned: mounir)

Details

Attachments

(1 file)

Patch
2.86 KB, patch
smaug
: review+
mounir
: checkin+
Details | Diff | Splinter Review 
Its very confusing to see things that inherit from nsDOMEventTargetHelper second or third and wonder about why that is safe.
What does not inherit from *Helper first ?
BluetoothDevice, BluetoothAdapter, SMSManager, SMSRequest
Attached patch Patch — — Splinter Review 
Assignee: nobody → mounir
Status: NEW → ASSIGNED

        Attachment #610171 -
        Flags: review?(khuey)

        Attachment #610171 -
        Flags: review?(khuey) → review+

    
  

        Attachment #610171 -
        Flags: checkin+

    
    

    
  
Oups, I didn't realize you did the review Olli. I just pushed the patch to inbound with r=khuey...

    
  
Flags: in-testsuite-
Target Milestone: --- → mozilla14

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/7b18a4980189
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: