Closed
Bug 739883
Opened 12 years ago
Closed 12 years ago
decomtaminate impl of GetSummary() on accessible tables
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: tbsaunde, Assigned: maxli)
References
Details
(Whiteboard: [good first bug][mentor=trev.saunders@gmail.com][lang=c++])
Attachments
(1 file, 1 obsolete file)
7.35 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
see procedure in bug 739882 accept this time with GetSummary()
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → maxli
Attachment #615206 -
Flags: feedback?(trev.saunders)
Comment 2•12 years ago
|
||
Comment on attachment 615206 [details] [diff] [review] Patch (v1) Review of attachment 615206 [details] [diff] [review]: ----------------------------------------------------------------- f=me with comments addressed, requesting r from Trevor ::: accessible/src/generic/ARIAGridAccessible.h @@ +65,5 @@ > // nsIAccessibleTable > NS_DECL_OR_FORWARD_NSIACCESSIBLETABLE_WITH_XPCACCESSIBLETABLE > > + // TableAccessible > + virtual void Summary(nsString& aSummary); you don't need to override it since it does the same as TableAccessible::Summary ::: accessible/src/html/nsHTMLTableAccessible.cpp @@ +561,2 @@ > > + table->GetSummary(aSummary); I'm not sure whether things like <div style="display: table"> implement nsIDOMHTMLTableElement interface, it's safer to have null check like if (table) table->GetSummary(aSummary); ::: accessible/src/xul/nsXULListboxAccessible.h @@ +104,5 @@ > // nsIAccessibleTable > NS_DECL_OR_FORWARD_NSIACCESSIBLETABLE_WITH_XPCACCESSIBLETABLE > > + // TableAccessible > + virtual void Summary(nsString& aSummary); you don't need it as well ::: accessible/src/xul/nsXULTreeGridAccessible.h @@ +60,5 @@ > // nsIAccessibleTable > NS_DECL_OR_FORWARD_NSIACCESSIBLETABLE_WITH_XPCACCESSIBLETABLE > > + // TableAccessible > + virtual void Summary(nsString& aSummary); same
Attachment #615206 -
Flags: review?(trev.saunders)
Attachment #615206 -
Flags: feedback?(trev.saunders)
Attachment #615206 -
Flags: feedback+
Assignee | ||
Comment 3•12 years ago
|
||
Comments addressed
Attachment #615206 -
Attachment is obsolete: true
Attachment #615206 -
Flags: review?(trev.saunders)
Attachment #615231 -
Flags: review?(trev.saunders)
Reporter | ||
Comment 4•12 years ago
|
||
Comment on attachment 615231 [details] [diff] [review] Patch v2 >+ nsAutoString summary(aSummary); >+ mTable->Summary(summary); don't pass anything to the nsAutoString constructor. r=me with that
Attachment #615231 -
Flags: review?(trev.saunders) → review+
Comment 5•12 years ago
|
||
Comment on attachment 615231 [details] [diff] [review] Patch v2 >+nsHTMLTableAccessible::Summary(nsString& aSummary) > { > nsCOMPtr<nsIDOMHTMLTableElement> table(do_QueryInterface(mContent)); >- NS_ENSURE_TRUE(table, NS_ERROR_FAILURE); >- >- return table->GetSummary(aSummary); >+ empty line should be empty (no spaces) I'll fix nits before landing
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3302067526f6
Target Milestone: --- → mozilla14
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3302067526f6
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•