739898 - Stop using enablePrivilege in test_bug480509.html

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

Stop using enablePrivilege, add an API to SpecialPowers to set a property to a value and use it to set xhr.channel.notificationsCallback.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 610020 [details] [diff] [review]
v1

r=me.  I'm impressed there was no eval involved in the impl!  ;)

Comment 2

[Josh Matthews [:jdm]]

Are you able to use |SpecialPowers.wrap(req).channel.notificationCallbacks = foo| instead?

Comment 3

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba46fc01fb32

I'll file a new bug to try the SpecialPowers.wrap method.

Comment 4

[Peter Van der Beken [:peterv]]

http://hg.mozilla.org/mozilla-central/rev/183eed448b9d

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/ba46fc01fb32

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/ba46fc01fb32