740192 - Screen orientation needs a specific security model for installed web apps

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Right now we can't know if a web app is installed or not from C++ (bug 725397) but as soon as we can, we should allow them to change the orientation as they want (ie. no need to be fullscreen).
Also, we might have to handle a default orientation value. Right now, we always revert to Firefox Mobile default orientation when ORIENTATION_NONE is used but we will have to use the app default orientation instead.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 2

[Justin Lebar (not reading bugmail)]

Comment on attachment 622859 [details] [diff] [review]
Patch v1

Review of attachment 622859 [details] [diff] [review]:
-----------------------------------------------------------------

>-    bool fullscreen;
>-    doc->GetMozFullScreen(&fullscreen);
>-    if (!fullscreen) {
>-      *aReturn = false;
>-      return NS_OK;
>+    // Non-app need to be fullscreen.
>+    if (!static_cast<nsGlobalWindow*>(GetOwner())->IsPartOfApp()) {
>+      bool fullscreen;
>+      doc->GetMozFullScreen(&fullscreen);
>+      if (!fullscreen) {
>+        *aReturn = false;
>+        return NS_OK;
>+      }
>     }

Make the comment positive, please:

 Apps and frames contained in apps can lock orientation.  But non-apps can lock orientation only if they're fullscreen.

Comment 3

[Mounir Lamouri (:mounir)]

http://hg.mozilla.org/mozilla-central/rev/c3b5e70e85e7