74021 - Stand alone window Close File->Close menu is gray out

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[fenella]

Linux (2001-03-29-08 mtrunk)
Win32 (2001-03-29-06 mtrunk)
Mac (2001-03-29-04 mtrunk)
1. Select the Inbox folder
2. From the Thread pane, double click on a message
3. Stand alone window comes up.
4. Click on the File menu
Actual result: Observe the Close sub-menu is gray out.
Ctl-w is disabled. I have to use the X widget to close the Stand alone window
Expected result: Close submenu should not be gray out

This occurs on all platforms.

Comment 1

[scottputterman]

I see this too. marking nsbeta1+

Comment 2

[scottputterman]

reassigning to ssu

Comment 3

[Sean Su]

Attachment: patch attempt #1

Comment 4

[Sean Su]

I just talked to bhuvan, and I'm going to rewrite the patch a different way in 
the hopes that this will not happen again in the future (for whoever updates 
the menus).

Comment 5

[Sean Su]

Attachment: patch attempt #2 (added comments)

Comment 6

[racham]

r=racham.

Sean, ping Seth for superreview. I am thinking there got to be someother way
also to do this. He will let us know if there are any alternate ways to do this.

Comment 7

[(not reading, please use [e-mail] instead)]

this seems like a hack.

how is navigator handling the close command?

Comment 8

[Sean Su]

I could not understand how the navigator window handles the cmd_close command.  
However, the closest thing I found was with the Editor window.  Given the editor 
window, I came up with another patch that works as well.

Comment 9

[Sean Su]

Attachment: patch attempt #3

Comment 10

[Sean Su]

Attachment: patch attempt #4 (makes it work under the 3pane window too)

Comment 11

[Blake Ross]

r=blake

Comment 12

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 13

[scottputterman]

According to Bonsai it looks like this got checked in so marking fixed.

Comment 14

[Sean Su]

yes.  it was checked in last night.  thanks.

Comment 15

[esther]

Using builds 2001-04-25 on window this is fixed completley.  On Mac and Linux 
the menu is still disabled (as is 4 or 5 others) until you click on the window 
to set focus.  Not as bad as originaly reported because of the workaround, but 
not fixed completely.  Reopening

Comment 16

[Sean Su]

The menu being disabled until the body of the message is clicked is a different 
bug (see bug 76745).

Comment 17

[Ninoschka Baca]

Build 2001-04-02-04: WinMe
Build 2001-04-02-08: Mac 9.04
Build 2001-04-03-08: Linux
Verified Fixed.