740375 - get rid nsIAccessible innerHTML method

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

1) remove innerHTML method from nsIAccessible interface (http://mxr.mozilla.org/mozilla-central/source/accessible/public/nsIAccessible.idl?force=1#111)
2) bump uuid of nsIAccessible interface
3) remove GetInnerHTML implementation from nsAccessible and nsApplicationAccessible (see accessible/src/base folder)
4) move the logic of nsAccessible::GetInnerHTML to nsAccessNodeWrap::get_innerHTML (see accessible/src/msaa) where it's used

Comment 1

[Trevor Saunders (:tbsaunde)]

(In reply to alexander :surkov from comment #0)
> 1) remove innerHTML method from nsIAccessible interface
> (http://mxr.mozilla.org/mozilla-central/source/accessible/public/
> nsIAccessible.idl?force=1#111)

any particular reason you want to remove this method?  it doesn't completely make sense or really have a clear purpose,but it doesn't seem its really hurting any one either.

> 4) move the logic of nsAccessible::GetInnerHTML to
> nsAccessNodeWrap::get_innerHTML (see accessible/src/msaa) where it's used

it looks like it already uses its own logic which is the same.  Although perhaps it should use something other than qi and nsIDOMHTMLElement

Comment 2

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #1)
> (In reply to alexander :surkov from comment #0)
> > 1) remove innerHTML method from nsIAccessible interface
> > (http://mxr.mozilla.org/mozilla-central/source/accessible/public/
> > nsIAccessible.idl?force=1#111)
> 
> any particular reason you want to remove this method?  it doesn't completely
> make sense or really have a clear purpose,but it doesn't seem its really
> hurting any one either.

this method is just a shortcut around HTML element innerHTML, doesn't make sense to dupe it on accessibility layer

> > 4) move the logic of nsAccessible::GetInnerHTML to
> > nsAccessNodeWrap::get_innerHTML (see accessible/src/msaa) where it's used
> 
> it looks like it already uses its own logic which is the same.  Although
> perhaps it should use something other than qi and nsIDOMHTMLElement

you're right, I missed that (it was late night for me :) ) So no 4) item.

Comment 3

[Mark Capella [:capella]]

Attachment: Patch (v1)

Looks fairly simple, built out ok, passed all mochitest-a11y tests ...

Comment 4

[Trevor Saunders (:tbsaunde)]

landed https://hg.mozilla.org/integration/mozilla-inbound/rev/57bd8957e1b4

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/57bd8957e1b4