740452 - client.mk: add a convenience target for check-sync-dirs so the test can be run independent of configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Joey Armstrong [:joey]]

Attachment: new target for check-sync-dirs so test can be run independent of configure

Code consolidation and will be helpful for submission scripts to trap silly errors before they reach try.

Comment 2

[Joey Armstrong [:joey]]

ping on the code review

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 610587 [details] [diff] [review]
new target for check-sync-dirs so test can be run independent of configure

Review of attachment 610587 [details] [diff] [review]:
-----------------------------------------------------------------

::: client.mk
@@ +425,5 @@
> +## Sanity check $X and js/src/$X are in sync
> +.PHONY: check-sync-dirs
> +check-sync-dirs: check-sync-dirs-build check-sync-dirs-config
> +check-sync-dirs-%:
> +	@$(PYTHON) $(TOPSRCDIR)/js/src/config/check-sync-dirs.py $(TOPSRCDIR)/js/src/$(subst check-sync-dirs-,$(NULL),$@) $(TOPSRCDIR)/$(subst check-sync-dirs-,$(NULL),$@)

Can't you just use $* here instead of this subst?

Comment 4

[Joey Armstrong [:joey]]

(In reply to Ted Mielczarek [:ted] from comment #3)
> Comment on attachment 610587 [details] [diff] [review]
> new target for check-sync-dirs so test can be run independent of configure
> 
> Review of attachment 610587 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: client.mk
> @@ +425,5 @@
> > +## Sanity check $X and js/src/$X are in sync
> > +.PHONY: check-sync-dirs
> > +check-sync-dirs: check-sync-dirs-build check-sync-dirs-config
> > +check-sync-dirs-%:
> > +	@$(PYTHON) $(TOPSRCDIR)/js/src/config/check-sync-dirs.py $(TOPSRCDIR)/js/src/$(subst check-sync-dirs-,$(NULL),$@) $(TOPSRCDIR)/$(subst check-sync-dirs-,$(NULL),$@)
> 
> Can't you just use $* here instead of this subst?

Nice, yes that would do the trick and will be more efficient.

Comment 5

[Joey Armstrong [:joey]]

Attachment: move check-sync-dirs test to a named target so it can be run indepen dent of configure

same patch as last time with $(subst ) replaced with $* per Ted's suggestion.
r=ted

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7ebb831c329

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/e7ebb831c329