740467 - Make test_XHR_timeout.js use addEventListener(..., obj, ...) instead of on* = obj

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 1

[Alex Vincent [:WeirdAl]]

I object to this.  I had a reason for using on*.  The spec said the ontimeout attribute had to exist and map to a timeout event listener.  This patch removes the test for ontimeout working.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Ok, then we need to test that differently.  Per spec onfoo properties don't accept objects with handleEvent methods, only functions.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Yeah, kyle is right.  I should have noticed the problem in the xhr.timeout tests.

Comment 4

[Alex Vincent [:WeirdAl]]

I agree - the code should've caught that... but I think that should be a separate bug.

I'd feel better if the test file itself were cloned, and the clone used the addEventListener approach.

Comment 5

[Peter Van der Beken [:peterv]]

Attachment: v2

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

To be clear, when we land bug 740069 this test will stop working if we don't do anything to it.

Peterv is going to post a new patch that addresses your comments.

Comment 7

[Peter Van der Beken [:peterv]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5561efcb19f2

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5561efcb19f2