740482 - Create nice breakpoint icons for the SourceEditor in the Debugger

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Rob Campbell [:rc] (:robcee)]

The SourceEditor should have nicer icons for showing breakpoints.

Comment 1

[Rob Campbell [:rc] (:robcee)]

Also need a "current line arrow" icon.

Comment 2

[Rob Campbell [:rc] (:robcee)]

cc'ing shorlander.

I'll add a screencap with the current buttons for examination.

Comment 3

[Stephen Horlander [:shorlander]]

Attachment: Breakpoint Icon Mockup

Comment 4

[Rob Campbell [:rc] (:robcee)]

darn, I never did add that screencap. Do you need one?

Those icons look pretty sweet. Also, can I have that color theme for the editor? :)

Comment 5

[Rob Campbell [:rc] (:robcee)]

mihai: does this look feasible or are we stuck using n x n images in the gutter? This looks like it'd be better implemented in CSS than using an image.

Comment 6

[Paul Rouget [:paul]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #4)
> darn, I never did add that screencap. Do you need one?
> 
> Also, can I have that color theme for the editor?

This should happen here: bug 715472 (not sure if you meant to implement the theme here)

Comment 7

[Mihai Sucan [:msucan]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #5)
> mihai: does this look feasible or are we stuck using n x n images in the
> gutter? This looks like it'd be better implemented in CSS than using an
> image.

The AnnotationRuler used for the debugger icons does not "communicate" in any way with the LineNumberRuler, unfortunately. This code comes from upstream.

From CSS we can only change the icons and a bit of styling for the AnnotationRuler.

If we want the design as proposed by shorlander (I want it!) we need to write a bit of JS code: write our own LineNumberRuler that allows us to do what we need. I doubt this is code we need to go upstream for - we can handle our editor UI as we see fit.

Thoughts?

Comment 8

[Rob Campbell [:rc] (:robcee)]

prioritizing as P2.

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Treetwisty as the location indicator

If we don't get new icons in time, how about using the treetwisty arrow as the current line indicator?

Comment 10

[Rob Campbell [:rc] (:robcee)]

what does that look like? I think it'll be offset won't it?

Comment 11

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Current icons

Comment 12

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: The Treetwisty icon

(In reply to Rob Campbell [:rc] (:robcee) from comment #10)
> what does that look like? I think it'll be offset won't it?

Yes, I think it's a little more offset than the current icon. At least with the dumb patch that I attached.

Comment 13

[Rob Campbell [:rc] (:robcee)]

Attachment: breakpoint-icons

simple patch to replace the current icons with shorlander's improved ones.

These still suffer from some funny offsets.

Comment 14

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/1a1529306022

Comment 15

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/1a1529306022