Closed
Bug 740502
Opened 12 years ago
Closed 12 years ago
Opening a previous conversation causes character encoding error
Categories
(Thunderbird :: Instant Messaging, defect)
Tracking
(thunderbird13 fixed)
RESOLVED
FIXED
Thunderbird 14.0
Tracking | Status | |
---|---|---|
thunderbird13 | --- | fixed |
People
(Reporter: Fallen, Assigned: florian)
Details
Attachments
(1 file)
840 bytes,
patch
|
clokep
:
review+
Bienvenu
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
STR: 1. Create a random conversation and write something 2. Close the conversation 3. Click on the contact, it will open the previous conversation Results: Error: The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must to be declared in the document or in the transfer protocol. Source File: chrome://chat/content/conv.html Line: 0
Assignee | ||
Comment 1•12 years ago
|
||
I started seeing this error message today too. I suspect we are seeing it now because bug 737022 has been fixed.
Assignee | ||
Comment 2•12 years ago
|
||
Here's a trivial fix. However this code depends on bug 713825 which was fixed in Mozilla 12, so we can't take this patch for Instantbird immediately.
Assignee: nobody → florian
Attachment #613633 -
Flags: review?(clokep)
Comment 3•12 years ago
|
||
Comment on attachment 613633 [details] [diff] [review] Patch This change seems fine Florian.
Attachment #613633 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 4•12 years ago
|
||
http://hg.mozilla.org/comm-central/rev/8feb1f71d7c1
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 613633 [details] [diff] [review] Patch [Approval Request Comment] User impact if declined: harmless error message in the error console each time an IM conversation is displayed. I'm not sure if this meets the criteria for landing on comm-aurora as a chat polish fix or not, so requesting approval just in case it does, although I don't feel strongly either way.
Attachment #613633 -
Flags: approval-comm-aurora?
Updated•12 years ago
|
Attachment #613633 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Comment 6•12 years ago
|
||
The transplant of this failed, did it need something extra?
Comment 7•12 years ago
|
||
That's because it had already landed: http://hg.mozilla.org/releases/comm-aurora/rev/15df6e2fb261
status-thunderbird13:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•