740606 - Consider disabling the rule view's context menu

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Dave Camp (:dcamp)]

The rule view's context menu has a couple pretty nasty bugs (bug 736014 and 740603).

If the fixes for those are small and low-risk, we should get them in aurora.  If not, we should unhook the context menu in aurora.

Comment 1

[Dave Camp (:dcamp)]

Attachment: Disable the context menu

The fix for the dependent bugs hasn't landed yet, I think we should disabled this menu in 13.

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 613351 [details] [diff] [review]
Disable the context menu

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

if you wanted to cut down on patch size, you could just comment out the offending test line in the makefile and not hg remove the actual test file.

Up to you.

Requesting Aurora Approval. This will quickly short-circuit our context menu in Aurora (13) which will prevent the occurrence of some nasty bugs. Risk is low.

Comment 3

[Alex Keybl [:akeybl]]

Comment on attachment 613351 [details] [diff] [review]
Disable the context menu

[Triage Comment]
Approved for Aurora 13 - the patch looks fine as is.

Comment 4

[Dave Camp (:dcamp)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/53b9eca24671

Comment 5

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20100101 Firefox/13.0

Context menu now disabled. verified in 13 beta4, Windows 7, Mac OS 10.6, Ubuntu 12.04