74072 - if "mail.forward_message_mode" is 1, the pref panel shows "0", but the back end does "2"

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

two problems:

1) in 6.x, "mail.forward_message_mode" can only be 0 or 2.  (1 is obsolete)  
but if you migrated from 4.x, it looks like we don't convert it to 0 or 2 (if it
was 1).  this caused an JS exception in nsWidgetStateManager.js

2) nsWidgetStateManager.js can be made more robust.  here comes a patch for
that.

this problem can be generalized to any menulist / pref.  if the value isn't one
of the options in the menulist, we barf.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: make the .js more robust

Comment 2

[(not reading, please use [e-mail] instead)]

fix summary.

Comment 3

[Alec Flett]

sr=alecf

Comment 4

[(not reading, please use [e-mail] instead)]

of, the widget state manager is more robust.

no more horkage.

Comment 5

[laurel]

I think there's an old rusty bug about this migrated state from early 6.0 days.
 It's probably very confusing by now,so if I find it I'll mark it a duplicate of
this one.

Comment 6

[laurel]

The bug I was thinking of is bug 21219, which has an awful lot of commentary and
changed a bit over time.  I'll just refer to it here and let someone else decide
on what to do with it.

Comment 7

[Cavin Song]

Attachment: Convert 1 to 0 in 6.x for forward_message_mode option

Comment 8

[(not reading, please use [e-mail] instead)]

is that correct?

looking at MsgForwardMessage() in mailWindowOverlay.js, we treat 1 as "forward
as inline"

it might be that the pref UI shows 1 as 0, but the code treats 1 as 2.

please confirm

Comment 9

[(not reading, please use [e-mail] instead)]

the horked problem is fixed.

updating summary to reflect the remaining issue.

the proper fix is to fix the "back end" (mailWindowOverlay.js) to treat any
value other than 2 as 0.  the reason is the widget manager will show "0" in the
pref ui (since it is the first item in the menu list) if the value is anything
other that "0" or "2".

our pref ui should reflect what the back end will do when you reply / forward.

cavin, please update your fix to include the fix to mailWindowOverlay.js

Comment 10

[Cavin Song]

Attachment: Fixed "backend" to map 1 to 0

Comment 11

[(not reading, please use [e-mail] instead)]

Attachment: patch based on cavin's patch, with comments.

Comment 12

[(not reading, please use [e-mail] instead)]

the patch looks good, but let's think about this.

we are mapping "forward quoted" to "forward as attachment".

it seems that "forward inline" is closer to "forward quoted" than "forward as
attachment".

we should still keep the UI and the back end in sync, but perhaps we should go
the other way and map 1 to 2, instead of 0.

to do this, we'd keep the old logic in mailWindowOverlay.js, and reverse the
order of the menuitems in pref-composing_messages.xul

if we want to map 1 -> 0, cavin's patch is correct.

if we want to map 1 -> 2, it's not.

comments?

Comment 13

[Cavin Song]

Attachment: Mapp 1 to 2 (inline)

Comment 14

[(not reading, please use [e-mail] instead)]

fix checked in.

thanks cavin!

Comment 15

[laurel]

*** Bug 21219 has been marked as a duplicate of this bug. ***

Comment 16

[laurel]

OK using apr 18 commercial trunk build: linux rh6.2, mac OS 9.0 and win98.
1/quoted gets mapped to inline.

Comment 17

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 23098 has been marked as a duplicate of this bug. ***