740919 - gkmedias.dll should be in dependentlibs.list

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

When using the XPCOM glue from a directory which is not the same as xul.dll, as WebRT is going to, gkmedias.dll cannot be found/loaded. This is causing the WebRT patch to currently use some unfortunate workarounds such as using SetDllDirectory, which is fragile. Instead I'd just like to undo the delay-loading of gkmedias.dll and load it eagerly again via dependentlibs.list.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

So we can't delay load anything that we ship on Windows?

Comment 2

[Benjamin Smedberg]

Attachment: Remove delay-loading, add to dependentlibs.list, rev. 1

Comment 3

[Benjamin Smedberg]

We cannot delay-load it using the automatic windows mechanism. We could delay-load it using LoadLibrary.

Comment 4

[(not currently active) Ted Mielczarek]

Could we (at the expense of complicating the dependent libs loading) add an annotation to dependentlibs.list such that it only loads it if the executable is running from a different directory?

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 610972 [details] [diff] [review]
Remove delay-loading, add to dependentlibs.list, rev. 1

Review of attachment 610972 [details] [diff] [review]:
-----------------------------------------------------------------

:-(

Comment 6

[Benjamin Smedberg]

re: comment 4; yes it's technically possible, but I would prefer not to do that unless we have data saying that this matters: bug 712175 appears to be preemptively doing it and it's not clear why that's necessary.

Comment 7

[Benjamin Smedberg]

https://hg.mozilla.org/integration/mozilla-inbound/rev/522fb722cc09

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/522fb722cc09