740945 - remove unused and un-built nsSVGLeafFrame

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Daniel Holbert [:dholbert]]

Bug 696078 removed the Makefile-line for nsSVGLeafFrame.cpp and removed all uses of it, but the .cpp file itself remains.

Filing this bug on removing it, since it's dead code now.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

I'm doing a clobber build before requesting review, to be absolutely sure this is dead code.

Comment 2

[Robert Longson [:longsonr]]

The patch I submitted was supposed to rename this file...

> diff --git a/layout/svg/base/src/nsSVGLeafFrame.cpp b/layout/svg/base/src/SVGFELeafFrame.cpp
> copy from layout/svg/base/src/nsSVGLeafFrame.cpp
> copy to layout/svg/base/src/SVGFELeafFrame.cpp

Comment 3

[Daniel Holbert [:dholbert]]

Ah -- so it looks like you must've accidentally done "hg cp" instead of "hg mv" -- makes sense.

Thanks for the quick r+! :)

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec2d6134783b

Comment 5

[Robert Longson [:longsonr]]

(In reply to Daniel Holbert [:dholbert] from comment #3)
> Ah -- so it looks like you must've accidentally done "hg cp" instead of "hg
> mv" -- makes sense.
> 
> Thanks for the quick r+! :)

I didn't land it  :-)

Comment 6

[Robert Longson [:longsonr]]

All's well that ends well. I meant to do a move, shouldn't that have counted ;-)

Comment 7

[Daniel Holbert [:dholbert]]

(In reply to Robert Longson from comment #5)
> I didn't land it  :-)

(right -- but the "copy from" in the posted changeset patch indicates that it was a "hg cp".  If it had been a move, it would have said "rename from" instead of "copy from".)

In any case - very minor issue, & indeed all's well that ends well. :)

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ec2d6134783b