740957 - Webapp installer doorhanger should show a standard icon, not the icon related to the app

Status: VERIFIED FIXED

(Firefox Graveyard :: Web Apps, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Attachment: app install doorhanger

As I understand it, for spoofing reasons the doorhanger that offers the web app installation should not display the app icon, but rather our standard icon that represents a "web app". Is this correct?

(note: "web app" icon display in this screenshot is not final)

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: app install doorhanger

(previous file was corrupted for some reason)

Comment 2

[Jason Smith [:jsmith]]

Jen - Could you provide insight into this?

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 611020 [details]
app install doorhanger

Can someone from UX take a look and sign off or comment on this change?

Comment 4

[Jason Smith [:jsmith]]

Brian Dils, could you review this?

Comment 5

[Jason Smith [:jsmith]]

My opinion for the UX - I'd either go all or nothing here for the icon. Either include the icon for the app or don't include an icon at all. Putting the box there if the icon is being removed I don't think is a good idea, as I don't think it creates any value-add.

Comment 6

[Stephen Horlander [:shorlander]]

Comment on attachment 611020 [details]
app install doorhanger

The 64x64 icons for the notification panels are designed to be distinct and easily recognized in peripheral vision. See geolocation, password, etc. So the icon is desired.

Comment 7

[Jason Smith [:jsmith]]

(In reply to Stephen Horlander from comment #6)
> Comment on attachment 611020 [details]
> app install doorhanger
> 
> The 64x64 icons for the notification panels are designed to be distinct and
> easily recognized in peripheral vision. See geolocation, password, etc. So
> the icon is desired.

If the icon is desired, then I would suggest a different icon to be used. The open box does not provide context to a user that they are installing an app. We need an icon that provides better context that an app is being installed.

Comment 8

[Stephen Horlander [:shorlander]]

The icon for app installation is happening in bug 735680.

Comment 9

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

Comment 10

[Jason Smith [:jsmith]]

FYI - This bug does not fall in alignment with requirements in bug 738546. Please get clarity from product management on the direction for this, as fennec native & firefox need to be alignment on implementation for the icon on app install.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

It's not clear who exactly you mean by "product management", but they do not have final veto power on what we end up doing. This is a collaboration, so "product management" needs to engage with the visual design team and the engineers fixing these bugs to determine the best solution. That goes both ways.

Comment 12

[Jason Smith [:jsmith]]

(In reply to Gavin Sharp (use [e-mail] for email) from comment #11)
> It's not clear who exactly you mean by "product management", but they do not
> have final veto power on what we end up doing. This is a collaboration, so
> "product management" needs to engage with the visual design team and the
> engineers fixing these bugs to determine the best solution. That goes both
> ways.

I'm referring to Jen & Ragavan. Yeah, I agree collaboration needs to take place. The underlying concern I'm trying to watch out for here is consistency, given that the fennec native implementation is going to have the app icon on a prompt for install, but this bug is suggesting to do the opposite. We should aim for consistency across each implementation, given that falls in line with the apps vision for consistency.

Comment 13

[Stephen Horlander [:shorlander]]

While I am certainly a proponent of cross product consistency, we also need to be consistent internally. In this case that means this should look and act like other notification panels. Which means a clear and consistent notification icon, notification text and button labeled with the action to take.

If we need to also include the icon of the application that is asking to be installed, that's ok, it just can't take the place of the notification icon. So if that is a requirement then we have more design work to do to figure out how to include that.

Comment 14

[Madhava Enros [:madhava]]

(In reply to Jason Smith from comment #12)

> I'm referring to Jen & Ragavan. Yeah, I agree collaboration needs to take
> place. The underlying concern I'm trying to watch out for here is
> consistency, given that the fennec native implementation is going to have
> the app icon on a prompt for install, but this bug is suggesting to do the
      --------------------------------
> opposite. We should aim for consistency across each implementation, given
> that falls in line with the apps vision for consistency.

It is? Fennec's notification boxes don't include icons at the moment.

Jason - you're quite right - we should get some agreement on this. Can you post the bug number or wiki page for the mobile designs?

Comment 15

[Jason Smith [:jsmith]]

(In reply to Madhava Enros [:madhava] from comment #14)
> It is? Fennec's notification boxes don't include icons at the moment.

Right. It's coming down the pipeline though. See bug 738546.

> Jason - you're quite right - we should get some agreement on this. Can you
> post the bug number or wiki page for the mobile designs?

bug 738546 has some proposed UI designs Harald is working on.

Comment 16

[Jason Smith [:jsmith]]

FYI - Felipe you are good to go. See bug 738546.

Comment 17

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a4a992d1bef

Comment 18

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/9a4a992d1bef

Comment 19

[Jason Smith [:jsmith]]

Verified on Nightly.