740963 - [Skia] Handle non-multiple-of-two dash lengths in HelpersSkia::StrokeOptionsToPaint()

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[George Wright (:gw280) (needinfo me!)]

Skia requires that dash arrays are a multiple of two in size for SkDashPathEffect.

Comment 1

[George Wright (:gw280) (needinfo me!)]

Attachment: Bug 740963 - [Skia] Handle non-multiple-of-two dash lengths in HelpersSkia::StrokeOptionsToPaint()

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 611032 [details] [diff] [review]
Bug 740963 - [Skia] Handle non-multiple-of-two dash lengths in HelpersSkia::StrokeOptionsToPaint()


>+    if (aOptions.mDashLength % 2 == 0) {
>+      dashCount = aOptions.mDashLength;
>+    } else {
>+      dashCount = aOptions.mDashLength * 2;
>     }
>-    
>-    SkDashPathEffect* dash = new SkDashPathEffect(&pattern.front(), 
>-                                                  aOptions.mDashLength, 
>+
>+    SkScalar pattern[dashCount];

Please don't allocate this on the stack.

Comment 3

[George Wright (:gw280) (needinfo me!)]

Attachment: Bug 740963 - [Skia] Handle non-multiple-of-two dash lengths in HelpersSkia::StrokeOptionsToPaint()

Comment 4

[George Wright (:gw280) (needinfo me!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fa5f41ab5315

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fa5f41ab5315