741242 - Profiler address output broken by bug 739800 on Mac 64 bit

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Markus Stange [:mstange]]

Attachment: v1

%#x uses an int value which truncates 64 bit addresses to 32 bit. We need to use %#lx instead.
Do things still work on Windows with this change?

Comment 1

[Benoit Girard (:BenWa)]

I think we need '(long unsigned int)pc'.

Comment 2

[Vladan Djeric (:vladan)]

Comment on attachment 611316 [details] [diff] [review]
v1

%lx truncates the address on 64-bit windows

Let's do this:

snprintf(tagBuff, 1024, "l-0x%p\n", pc);

^^^ explicitly specifying "0x" because "%#p" outputs "OX"

Can you guys test this on 32-bit/64-bit Unix and Mac?

Comment 3

[Benoit Girard (:BenWa)]

Tested, %p appends 0x so we get it twice. Let's use some ifdefs here.

Comment 4

[Vladan Djeric (:vladan)]

Attachment: Use %#llx to print pointers

Comment 5

[Vladan Djeric (:vladan)]

Comment on attachment 611522 [details] [diff] [review]
Use %#llx to print pointers

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4f6c908dc17

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/d4f6c908dc17