741266 - document.open with 3 or more arguments should call OpenJS, not Open

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase

Right now it seems to call Open(), which makes the behavior wrong when opening a sized window.  Try the attached testcase.

Changing to OpenJS here makes things work right.  Since we really only support document.open() from script, that seems like a reasonable change to me.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: document.open with 3 or more arguments should invoke the scriptable version of window.open, not the noscript one.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 611339 [details] [diff] [review]
document.open with 3 or more arguments should invoke the scriptable version of window.open, not the noscript one.

Review of attachment 611339 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/document/test/test_bug741266.html
@@ +20,5 @@
> +
> +/** Test for Bug 741266 **/
> +var w = window.open("", "", "width=100,height=100");
> +is(w.innerHeight, 100, "Popup height should be 100 when opened with window.open");
> +is(w.innerWidth, 100, "Popup widthshould be 100 when opened with window.open");

Nit: space in the message (twice)

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d83c1ffb7397 with that nit fixed.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

backed out cause the newly added test fails on Windows
https://hg.mozilla.org/integration/mozilla-inbound/rev/3be23dcd43e4

87069 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/document/test/test_bug741266.html | Popup width should be 100 when opened with window.open - got 114, expected 100
87071 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/document/test/test_bug741266.html | Popup width should be 100 when opened with document.open - got 114, expected 100

Comment 5

[Boris Zbarsky [:bzbarsky]]

Bah.  That's totally broken...

I'll rework the test a bit.

Comment 6

[Boris Zbarsky [:bzbarsky]]

With the fixed test: https://hg.mozilla.org/integration/mozilla-inbound/rev/a7ae9d421848

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/a7ae9d421848