741275 - Add back support for making a thumbnail after pageload

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Bug 740146 removed the screenshot code, but also removed making a thumbnail after a pageload. We should add that back:

https://hg.mozilla.org/integration/mozilla-inbound/rev/d3f20d0371d0#l1.180

Right now, we only make thumbnails when opening the TabTray. About:Home also depends on thumbnails and might be empty until the TabTray is displayed.

Comment 1

[Geoff Brown [:gbrown]]

Darn, how did that happen? Purely unintentional...

Comment 2

[Geoff Brown [:gbrown]]

Attachment: add back thumbnail creation on page load

I think it's as simple as calling getAndProcessThumbnailForTab - it seems to work for me - and that the remainder of the old SessionSnapshotRunnable is no longer relevant.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 611498 [details] [diff] [review]
add back thumbnail creation on page load


>+        if (Tabs.getInstance().isSelectedTab(tab)) {
>+            GeckoAppShell.getHandler().postDelayed(new Runnable() {
>+                public void run() {
>+                    getAndProcessThumbnailForTab(tab);
>+                }
>+            }, 500);
>+        }

Just remove the isSelected check. I'm pretty sure we want to always make the thumbnail on a pageload.

Comment 4

[Geoff Brown [:gbrown]]

Attachment: add back thumbnail creation on page load

Removed check for selected tab and re-tested. r=mfinkle carried.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Needed for proper thumbnail creation

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/553c1d8965ca

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/553c1d8965ca

Comment 8

[Cristian Nicolae (:xti)]

Thumbnail is created after pageload on the latest Nightly. Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-22)
Device: Galaxy Nexus
OS: Android 4.0.2