741734 - "paste withoug formatting" doesn't fire OnPaste event in contenteditable element

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Thomas Broyer]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/536.5 (KHTML, like Gecko) Chrome/19.0.1084.1 Safari/536.5

Steps to reproduce:

Ctrl+Shift+V (on Windows or Linux; Cmd+Option+Shift+V on Mac) within a contenteditable div.


Actual results:

Text pasted without formatting, but no event is fired.


Expected results:

A paste event should have been fired.

Try it here http://jsfiddle.net/DW57a/

Comment 1

[Thomas Broyer]

Paste and PasteTransferable both start with a call to FireClipboardEvent(NS_PASTE), but not PasteNoFormatting:
http://hg.mozilla.org/mozilla-central/file/c410b2d6d570/editor/libeditor/html/nsHTMLDataTransfer.cpp#l1625

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 611881 [details] [diff] [review]
Patch (v1)

Review of attachment 611881 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/tests/test_bug410986.html
@@ +57,4 @@
>            synthesizeKey("V", {accelKey: true});
>            isnot(ed.innerHTML.indexOf("<span style=\"color: green;\">green text</span>"), -1,
>                  "Content should be pasted in HTML format");
> +          is(gPasteEvents, 2, "One paste event must be fired");

Fix string

Comment 4

[(no longer active)]

Landed https://hg.mozilla.org/integration/mozilla-inbound/rev/afff429aaf9a with a bad commit message, backed it out in https://hg.mozilla.org/integration/mozilla-inbound/rev/ca51e71184bb and relanded in https://hg.mozilla.org/integration/mozilla-inbound/rev/a154bf84abdb.

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/a154bf84abdb