Closed
Bug 742091
Opened 12 years ago
Closed 12 years ago
Texture format detection broken by 740372
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: romaxa, Assigned: romaxa)
References
()
Details
Attachments
(2 files, 1 obsolete file)
1.65 KB,
patch
|
gw280
:
review+
|
Details | Diff | Splinter Review |
1.71 KB,
patch
|
romaxa
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/gfx/gl/GLContextProviderEGL.cpp#851 - become broken after moving mobile optimize into common content<->format optimizer.. I guess android XUL builds also got RGB/BGR colors swapped
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → romaxa
Attachment #612007 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #612031 -
Flags: review?(gwright)
Assignee | ||
Updated•12 years ago
|
Comment 2•12 years ago
|
||
Comment on attachment 612031 [details] [diff] [review] Seems to work everywhere Review of attachment 612031 [details] [diff] [review]: ----------------------------------------------------------------- lgtm ::: gfx/gl/GLContextProviderEGL.cpp @@ -866,5 @@ > } else { > - if (mUpdateFormat == gfxASurface::ImageFormatRGB24) { > - // RGB24 means really RGBX for Thebes, which means we have to > - // use the right shader and ignore the uninitialized alpha > - // value. Can you add this comment back in?
Attachment #612031 -
Flags: review?(gwright) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #612337 -
Flags: review+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/77a9eff9bf12
Comment 5•12 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/77a9eff9bf12
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•