742141 - Need to support the 'float' type in the WebIDL parser

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Attachment: Maybe patch

Right now, the parser dies on it.

Attached patch makes things work, but may be bogus.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

The "Maybe patch" fixes this, but it's a step in the wrong direction because it makes float consts more broken than they already are.  This patch doesn't make float consts any worse.

Comment 2

[Justin Lebar (not reading bugmail)]

So FLOAT_ is the "float" keyword, while FLOAT is a floating-point literals?

If so, can we indicate in the token names which are keywords and which are literals, by putting a prefix / suffix on the names?  That would be helpful for sanity, I think.  (It looks like the spec does this, using "Literal" as a suffix for the literals tokens.)

Comment 3

[Justin Lebar (not reading bugmail)]

Comment on attachment 619526 [details] [diff] [review]
Patch

r=me, but I'd really prefer for us to change to a saner set of token names.  But you can do that as a followup if you'd like...

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Float and FloatLiteral sound good to me.  The *Literal stuff is pretty new in the spec, I think.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/users/khuey_mozilla.com/webidl-parser/rev/3e01e8dc99b6
http://hg.mozilla.org/mozilla-central/rev/f1a9dac39546