Closed
Bug 742200
Opened 12 years ago
Closed 12 years ago
optional jsval arguments ('any' in the IDL) should become JSVAL_VOID, not JSVAL_NULL, when there was no argument passed
Categories
(Core :: DOM: Core & HTML, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
674 bytes,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
Right now we do JSVAL_NULL converted to the argument type for all optional arguments without a default value.
|
Assignee | |
Comment 1•12 years ago
|
||
Actually, I think we can just use JSVAL_VOID across the board here; for everything but string arguments it's identical, and for string arguments I think the JSVAL_VOID behavior is more per spec.
|
|
Assignee | |
Comment 2•12 years ago
|
||
Assignee: nobody → bzbarsky
Attachment #613374 -
Flags: review?(peterv)
|
|
Assignee | |
Updated•12 years ago
|
Priority: -- → P2
Whiteboard: [need review]
|
||
Updated•12 years ago
|
Attachment #613374 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a021e58d714f
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla14
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a021e58d714f
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•