742207 - Use the same code for determining size of SVG documents and other synthetic documents

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

+++ This bug was initially created as a clone of Bug #710126 +++

Web pages that are wider than they are long can't be viewed in full. This is especially an issue with images and presumably video.

Bug 710126 fixed this for image documents but not for other synthetic documents (video, and possibly SVG).  This patch should extend the same fix to work for all synthetic document types.  I haven't tested it yet.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Thanks for doing this, I had it on my to-do list. The only question I have about this if the SVG-specific code in Tab.getPageSize needs to be taken out with this change. If SVGs render properly centered without that code then we should take it out.

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2

This works fine, although I'm not sure if it's fixing any real problems.  Videos seem to be rendered at the correct size/scale with or without this patch.  I can't reproduce bug 712065 with or without this patch, even if I back out the fix from bug 712065.

Comment 3

[Matt Brubeck (:mbrubeck)]

By the way, I think we should wait until after we've branched for our "1.0" native release before landing this, to avoid adding any risk for this non-critical fix.

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2 (for real)

Forgot to hg qref.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 612344 [details] [diff] [review]
patch v2 (for real)

Review of attachment 612344 [details] [diff] [review]:
-----------------------------------------------------------------

Agreed.

Comment 6

[Matt Brubeck (:mbrubeck)]

Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb238b1ab6dc

QA note: As mentioned in comment 2, this patch does not fix any reproducible bugs; it is just code cleanup at this point and it should not have any visible effects.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Just to be clear, it would be good if QA verified that it has no visible effects when loading different types of documents (HTML, SVG, any image, video, etc.)

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fb238b1ab6dc