742425 - Remove the compartment-entering in WrapNewBindingObject

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

I talked to Blake and jorendorff; the claim is that cx and JS_THIS should always be in the same compartment for a jsnative, and since we pass the JS_THIS as the scope to WrapNewBindingObject, we can just assert that we're in the right compartment.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove the extra compartment-entering code we don't need.

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 612245 [details] [diff] [review]
Remove the extra compartment-entering code we don't need.

Review of attachment 612245 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Boris Zbarsky (:bz) from comment #0)
> the claim is that cx and JS_THIS should
> always be in the same compartment for a jsnative

That'll be true for obj too if we don't use JSPROP_NATIVE_ACCESSORS, right?

Comment 3

[Boris Zbarsky [:bzbarsky]]

> That'll be true for obj too if we don't use JSPROP_NATIVE_ACCESSORS, right?

Yes.

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/projects/birch/rev/b6f1af93a4e6

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/b6f1af93a4e6