742626 - Allow indexedDB parent directory to not be the default profile directory

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[[:fabrice] Fabrice Desré]

Attachment: Use the "indexedDBPDir" directory

In b2g we will preload some indexedDB databases (eg. the settings db), like we preload the offline cache and the mozApps data. This happens at build time, before the first run of gecko, so we don't have yet a profile directory.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 612453 [details] [diff] [review]
Use the "indexedDBPDir" directory

Review of attachment 612453 [details] [diff] [review]:
-----------------------------------------------------------------

Hm... If this is just a build thing can we just use an environment variable rather than adding a new directory key?

Comment 2

[[:fabrice] Fabrice Desré]

It's not only at build time. We expect data to be there at runtime, and we don't have the profile directory ready before first run.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 612453 [details] [diff] [review]
Use the "indexedDBPDir" directory

Review of attachment 612453 [details] [diff] [review]:
-----------------------------------------------------------------

Ok!

Comment 4

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/28cfc474ab58

Comment 5

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/b87dcc5e00db - so far only Mac has finished debug xpcshell runs, but there you're failing 54 tests:

https://tbpl.mozilla.org/php/getParsedLog.php?id=11330849&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11330668&tree=Mozilla-Inbound

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/28cfc474ab58

Comment 7

[(no longer active)]

Backed out: https://hg.mozilla.org/mozilla-central/rev/b87dcc5e00db

Comment 8

[Gregor Wagner [:gwagner]]

Attachment: patch

Rebased.

Comment 9

[Gregor Wagner [:gwagner]]

I pushed to try again: https://tbpl.mozilla.org/?tree=Try&rev=46c8c835c22d

Comment 10

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 11

[Gregor Wagner [:gwagner]]

Ah I forgot the -u mercurial flag.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f0cb242f0e6

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6f0cb242f0e6