742669 - JS error after closing a selected IM conversation, breaking some parts of the Chat UI

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thunderbird Daily 2012-04-04, Windows XP SP 3 32-bit

After opening a chat with an IRC member by double-clicking his name and then moving the mouse over his name in the left sidebar and closing this chat, the IRC channel again gets focus, but the right column still shows "previous conversations" and not the lists of members of the IRC channel.

Comment 1

[Florian Quèze [:florian]]

In this case it seems only the top of the right pane (the conversation name and the channel topic) get updated. I'll need to investigate why this happens when closing a conversation (and the selection is moved automatically to the previous item in the list of conversations) and not when the user moves the selection.

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch

When this happens we have a JS strict warning:
components/imConversations.js, line 47: reference to undefined property this._purpleConv[this._currentTargetId]

This means that we are touching attributes of an imConversation that's already destroyed from the point of view of the imConversations service.

The attached patch contains a comment in the code explaining what was actually going wrong.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 630585 [details] [diff] [review]
Patch

Review of attachment 630585 [details] [diff] [review]:
-----------------------------------------------------------------

Fixed the problem, and looks good.

::: mail/components/im/content/imconv.xml
@@ +169,5 @@
>            this.convView.destroy();
>            this.convView.parentNode.removeChild(this.convView);
>          }
> +
> +        // If the conversation we are destroying was selected, we should

Nice, clear documentation.

Comment 5

[Florian Quèze [:florian]]

http://hg.mozilla.org/comm-central/rev/3a5b759c5a84

Comment 6

[Florian Quèze [:florian]]

Comment on attachment 630585 [details] [diff] [review]
Patch

[Approval Request Comment]
We want this fix for Tb15, as the bug causes some user visible issues in the UI.

Comment 7

[Florian Quèze [:florian]]

https://hg.mozilla.org/releases/comm-aurora/rev/c1e0f3526666