Closed
Bug 742725
Opened 12 years ago
Closed 12 years ago
Filelink offer reappears after converting a large file back to a regular attachment
Categories
(Thunderbird :: Message Compose Window, defect)
Tracking
(thunderbird13 fixed)
RESOLVED
FIXED
Thunderbird 14.0
Tracking | Status | |
---|---|---|
thunderbird13 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(1 file, 2 obsolete files)
6.79 KB,
patch
|
Bienvenu
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
STR: 1) Attach a large file in a compose window, causing the Filelink offer to appear 2) Convert the file to a Filelink 3) Convert the file back to a regular attachment What happens? The Filelink offer reappears. What's expected? Since I already know about Filelink, already used it, and decided not to, I really shouldn't hear about it again.
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Comment 1•12 years ago
|
||
It looks like we were calling the attachmentsAdded function inside attachmentsConverted. Fixes that, cleans bigFileObserver.js a little bit, and adds a test. -Mike
Assignee: nobody → mconley
Attachment #612628 -
Flags: review?(squibblyflabbetydoo)
Assignee | ||
Comment 2•12 years ago
|
||
squib: Just a note that the patch for bug 738299 needs to be applied before this one. -Mike
Comment 3•12 years ago
|
||
Comment on attachment 612628 [details] [diff] [review] Patch v1 Review of attachment 612628 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me by inspection. Assuming the tests pass, r=me. ::: mail/test/mozmill/cloudfile/test-cloudfile-notifications.js @@ +8,5 @@ > > let Cu = Components.utils; > let Cc = Components.classes; > let Ci = Components.interfaces; > +let Cr = Components.results; While we're here, maybe switch these to const? (Not that it really matters, but that's how I usually see these.)
Attachment #612628 -
Flags: review?(squibblyflabbetydoo) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Unbitrotting due to 744004 landing.
Attachment #612628 -
Attachment is obsolete: true
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Jim Porter (:squib) from comment #3) > Comment on attachment 612628 [details] [diff] [review] > Patch v1 > > Review of attachment 612628 [details] [diff] [review]: > ----------------------------------------------------------------- > > This looks good to me by inspection. Assuming the tests pass, r=me. > > ::: mail/test/mozmill/cloudfile/test-cloudfile-notifications.js > @@ +8,5 @@ > > > > let Cu = Components.utils; > > let Cc = Components.classes; > > let Ci = Components.interfaces; > > +let Cr = Components.results; > > While we're here, maybe switch these to const? (Not that it really matters, > but that's how I usually see these.) Funnily enough, it turns out that these are all predefined in the global scope. I'll excise them.
Assignee | ||
Comment 6•12 years ago
|
||
Removing Cc/Ci/Cu/Cr definitions.
Attachment #615344 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Attachment #615345 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 7•12 years ago
|
||
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/88c29b17c96d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Updated•12 years ago
|
Attachment #615345 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Assignee | ||
Comment 8•12 years ago
|
||
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/0a45d6df193b
status-thunderbird13:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•