742726 - Joining a channel on irc through the join channel dialog should be able to cope with a missing # or warn about it

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Mark Banner (:standard8)]

The join channel dialog asks me for a channel name. It doesn't ask for #<channel-name>.

Therefore I think it should be able to cope with either just '<channel-name>' or '#<channel-name>'

Comment 1

[Ludovic Hirlimann [:Usul]]

So we want to ban server only channels that starts with & ?

Comment 2

[Patrick Cloke [:clokep]]

(In reply to Mark Banner (:standard8) from comment #0)
> The join channel dialog asks me for a channel name. It doesn't ask for
> #<channel-name>.
> 
> Therefore I think it should be able to cope with either just
> '<channel-name>' or '#<channel-name>'

#<stuff> is the full channel name (not just the part after the #).

There are also a variety of other prefixes that could be used: http://tools.ietf.org/html/rfc2812#section-1.3 (and servers can define their own as well).

I'm not fully against this, I'd rather autofill a # as the default channel name that can be deleted instead of automatically adding a # if no prefix is given.

(Instantbird bug, with little information: https://bugzilla.instantbird.org/show_bug.cgi?id=909)

Comment 3

[Mark Banner (:standard8)]

There's other issues as well related to this as well, for example - if you select auto-join, and you haven't added #, then the invalid channel name gets added to your auto-pref accounts.

So we need a bit more validation here to get the right thing in the first instance before closing the dialog.

Comment 4

[Patrick Cloke [:clokep]]

This should be fixed after the porting of chat changes 6.