743179 - B2G SMS: error notification for REQUEST_GET_SMSC_ADDRESS failure is not fired

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

Bug 727319 add error notification for REQUEST_GET_SMSC_ADDRESS failure but it will actually never get fired for typo. The lines in REQUEST_GET_SMSC_ADDRESS handler:

  if (options.rilRequestError) {
    if (options.body) {

should be:

  if (options.rilRequestError) {
    if (options.fullBody) {

A better replacement might be checking `options.type == sendSMS` instead.

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Note that bug 740238 tries to remove SMSC pre-fetching related code, and this bug just falls into its target range. Since it's still under review & verification on Akami, fixing this bug is still necessary for now.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Attachment: check options.type in REQUEST_GET_SMSC_ADDRESS handler

Comment 3

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26a56a089f89

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/26a56a089f89