743226 - Installing new dictionaries leads to 404 page

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Jay Versluis]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:11.0) Gecko/20100101 Firefox/11.0
Build ID: 20120312181643

Steps to reproduce:

I was trying to install a new dictionary from the Spell Checking drop down. This is from an email composition window. This kindly supplied a list of installed dictionaries, and a link to "install new dictionary". I clicked that.


Actual results:

This took me to a new Thunderbird tab (nice!) with a 404 page, saying add-on not found. It's not a biggie, since there was a link on the left hand side which pointed me to the right direction. However, being an occasional software developer myself, I thought I'd let you guys know about this.


Expected results:

The link should have gone to the correct place immediately, without the 404 page in the middle.

Comment 1

[Hashem Masoud]

(In reply to Jay Versluis from comment #0)
Confirmed here:
User Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120327 Thunderbird/11.0.1
Application Build ID: 20120327115527

Write ➯ Options ➯ Spell Checking ➯ Language ➯ Download more dictionaries... (error page).

Comment 2

[Onno Ekker [:nONoNonO UTC+1]]

Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko/20100101 Firefox/11.0

This also fails in Firefox, so it's probably a core bug.
Firefox: Right click textarea -> Languages -> Add Dictionaries...

Looks like it should now go to https://addons.mozilla.org/[language]/[application]/language-tools/

Comment 3

[Mark Banner (:standard8)]

This is a major regression in AMO link functionality, breaking all older versions and current versions of Firefox & Thunderbird. It looks like it could be fixed by a redirect from

https://addons.mozilla.org/%LOCALE%/%APP%/dictionaries/

to

https://addons.mozilla.org/%LOCALE%/%APP%/language-tools/

but I believe that if this is the new location then new versions of Firefox, Thunderbird & all should be updated to point to this new location rather than the old one.

Comment 4

[Wil Clouser [:clouserw]]

https://github.com/mozilla/zamboni/commit/a0b6ec77ca49e6fdb8b1758d25b7676ff98d8e22

Comment 5

[Wil Clouser [:clouserw]]

I added a redirect back in for /dictionaries/  It'll be on addons-dev.allizom.org in a second.

Comment 6

[Onno Ekker [:nONoNonO UTC+1]]

I've temporarely changed setting spellchecker.dictionaries.download.url in Thunderbird to addons-dev.allizom.org and can confirm it works! Good job. Don't know how to test this in Firefox, because I can't find the pref there...

Comment 8

[Alex Keybl [:akeybl]]

We're a week out from Firefox 12's release. It sounds like this can be at least temporarily resolved server side. Please email [e-mail] today if you still believe this needs to go into our final beta. Otherwise, we'll first resolve this for FF13 if any further action is necessary.

Comment 9

[Alex Keybl [:akeybl]]

Just tested - everything looks fine to me on FF13. This must have been rolled out to production.