743631 - Check keycodes instead of scancodes when detecting keyevents

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Michael Wu [:mwu]]

The use of scancodes instead of keycodes was an old hack that has come back to bite me with devices that don't use normal linux scancodes.

Comment 1

[Michael Wu [:mwu]]

Attachment: Use keyCode instead of scanCode and use a lookup table

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 630744 [details] [diff] [review]
Use keyCode instead of scanCode and use a lookup table

>diff --git a/widget/gonk/GonkKeyMapping.h b/widget/gonk/GonkKeyMapping.h

>+#ifndef GONKKEYMAPPING_H
>+#define GONKKEYMAPPING_H
>+

Needs a license header.

>+/* See libui/KeycodeLabels.h for the mapping */
>+static const unsigned long kKeyMapping[] = {

I didn't review all of these individually.

r=me with license header.

Comment 3

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d04694a80016

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d04694a80016