Closed Bug 743844 Opened 12 years ago Closed 12 years ago

webrtc/signaling code crashes when multiple instances are running.

Categories

(Core :: WebRTC: Signaling, defect)

Product:
Core
Component:
WebRTC: Signaling
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla18

People

(Reporter: ehugg, Assigned: ehugg)

Details

(Keywords: crash, Whiteboard: [WebRTC], [blocking-webrtc+] [qa-])

Attachments

(1 file)

Fix to enable timers to work for more than instance on Linux/Mac
6.93 KB, text/plain
jesup
: feedback+
ehugg
: feedback+
Details 
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:11.0) Gecko/20100101 Firefox/11.0
Build ID: 20120310010316

Steps to reproduce:

All instances of SIPCC use the same names in the timer code - /tmp/CprTmrClient and /tmp/CprTmrServer.  This causes problems when multiple instances are running.
Comment on attachment 613431 [details]
Fix to enable timers to work for more than instance on Linux/Mac

Same fix for Linux/Mac adding PID to name.
Attachment #613431 - Flags: feedback?(snandaku)
Comment on attachment 613431 [details]
Fix to enable timers to work for more than instance on Linux/Mac

Since I wrote the code, I'm more than willing to + it!  :-)
Attachment #613431 - Flags: feedback?(rjesup)
Attachment #613431 - Flags: feedback?(ethanhugg)
Attachment #613431 - Flags: feedback+
Assignee: nobody → ethanhugg
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 613431 [details]
Fix to enable timers to work for more than instance on Linux/Mac

Would still like to find a way to move away from this CPR code.
Attachment #613431 - Flags: feedback?(ethanhugg) → feedback+
QA Contact: jsmith
Whiteboard: [WebRTC], [blocking-webrtc+]
Linux was fixed in bug 745349 (along with a bunch of others)

darwin timers weren't hit in that bug, so this needs to be landed on that file (and try to make it match the code in the linux patch already landed)
Comment on attachment 613431 [details]
Fix to enable timers to work for more than instance on Linux/Mac


This was pushed to Alder before the big rollup-review (bug 792188).

Related follow-on bug is here https://bugzilla.mozilla.org/show_bug.cgi?id=794240
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Severity: normal → critical
Keywords: crash
Target Milestone: --- → mozilla18
Attachment #613431 - Flags: feedback?(snandaku)
Whiteboard: [WebRTC], [blocking-webrtc+] → [WebRTC], [blocking-webrtc+] [qa-]
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: