Closed
Bug 743896
Opened 12 years ago
Closed 12 years ago
Fix test failure misattribution for timeouts in the unix testrunner
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: terrence, Assigned: terrence)
Details
Attachments
(1 file)
|
1.64 KB,
patch
|
dmandelin
:
review+
|
Details | Diff | Splinter Review |
In the unix task runner, when we kill tasks, we should be checking and returning bool if we kill, so that we then run waitpid in timeout mode. We weren't, so tasks were never failing with timeout, only with failure. It turns out, that this is not safe anyway, since this will race against signal delivery. We're better off just removing this hack and letting the timeout cutoff be fuzzy.
Attachment #613467 -
Flags: review?(dmandelin)
|
||
Updated•12 years ago
|
Attachment #613467 -
Flags: review?(dmandelin) → review+
|
Assignee | |
Comment 1•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/03cb4bb56621
|
||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/03cb4bb56621
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•