743997 - Make tap-targets for social links more obvious

Status: VERIFIED FIXED

(Pancake Graveyard :: Front-end, defect)

Description

[Deb Richardson [:dria] (plz NEEDINFO)]

Right now I have absolutely no idea what parts of the social links (ie: Twitter things) are actually hyperlinked, and there is no UI response at all when I tap things (no highlight of the tapped area and no throbber or loading indicator).

This makes it incredibly difficult to know if a tap has worked.  Pancake needs some sort of UI response for that as well as making it clear which parts are tappable (if not the whole shared item block).

Comment 1

[Deb Richardson [:dria] (plz NEEDINFO)]

So it turns out that the whole shared block is tappable, but the UI doesn't respond at all until the page starts loading.  This can often take a while and is confusing.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

bug 734239?

Comment 3

[Sam Foster [:sfoster] (he/him)]

See my questions in #734239. Is the current behavior what we want? 
Meanwhile maybe we can use a down or indeterminate state for the click area to give some immediate feedback to the user.

Comment 5

[Stuart Parmenter]

I believe Gordon changed the behavior here after it initially landed to only let you click on the icon and title.  I don't think this behavior is what we want.  I keep clicking on the largest area of most (the description) and it doesn't open.  We should go back to clicking on a larger area.

Comment 6

[Gordon Brander :gordonb]

Fixed in https://bitbucket.org/mozillapancake/pancake/changeset/60dded5b8546. Wrapped the entire post content in the .link trigger, allowing any part of the post to be clicked.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified fixed based on comment 6.