744464 - nsPlainTextSerializer.cpp:414:30: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Daniel Holbert [:dholbert]]

GCC 4.6.3 build warning:

nsPlainTextSerializer.cpp:414:30: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

from this chunk:
> 412   if (id == nsGkAtoms::head) {
> 413     --mHeadLevel;
> 414     NS_ASSERTION(mHeadLevel >= 0, "mHeadLevel < 0");

where mHeadLevel is a PRUint32 (and was when that assertion was added, in bug 418727)

Looks like the purpose here is to be sure we don't decrement a value that is at zero. We should probably be asserting that our value is nonzero before we decrement it.

Comment 1

[Daniel Holbert [:dholbert]]

MXR link to this chunk in the source:
http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsPlainTextSerializer.cpp?mark=414-415#412

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix: assert before we decrement

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/165ec2dea412

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/165ec2dea412