744981 - Share should share page title as well as URL

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Paul [pwd]]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:14.0) Gecko/20120412 Firefox/14.0a1
Build ID: 20120412030726

Steps to reproduce:

Opera for Android does this. It's convenient and useful, I'm not really sure why Fennec opts to only share the URL.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I'm not able to reproduce what you are seeing.

The title of the webpage is in the subject when you send off an email.  Opera doesn't show the title in twitter; neither do we since there's limited space.

Can you be more specific in where you are seeing the issue please?

Comment 2

[Paul [pwd]]

You're right, Tweetdeck, Tweakdeck and Twitter are shared without page title, while Whatsapp shares the page title.

Comment 3

[Richard Newman [:rnewman]]

Pocket also doesn't get the page title. But it doesn't when sharing a page from the Android 4.2 "Internet" browser, either.

As we found in Bug 799615, there are a bunch of different ways to send pages, some of which work better than others. I would like to explore this further at some point, because I think we might be able to make this work.

So if nobody minds, I'm going to reopen this and do some investigation.

Comment 4

[Richard Newman [:rnewman]]

Attachment: Part 0: rewrite openUriExternal. v1

Mark, please review or dispatch appropriately!

This part 0 rewrites openUriExternal to:

* Use early returns
* Eliminate C++-style aFoo naming
* Separate intent creation from activity launching
* Use more efficient/library code for things like query parsing
* Improve readability and style
* Add Javadocs and comments

It builds; tomorrow I will test it.

Comment 5

[Richard Newman [:rnewman]]

Attachment: Part 1: add title. v1

On top of that refactoring, the one-line change. Yes, it's a one-line change, but now we can read the function and understand what it's doing ;)

Again, I will test this tomorrow.

Comment 6

[Richard Newman [:rnewman]]

   https://hg.mozilla.org/integration/mozilla-inbound/rev/9e3edc87a446
   https://hg.mozilla.org/integration/mozilla-inbound/rev/8ac096b24cb0

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9e3edc87a446
https://hg.mozilla.org/mozilla-central/rev/8ac096b24cb0