74503 - Crash in ImageCache.cpp when cache disabled

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect, P4)

Description

[Peter "jag" Annema]

To prefs.js add:

user_pref("browser.cache.enable", false);

(Additionally, have:
user_pref("browser.enable.cache", false);
user_pref("browser.cache.disk.enable", false);
not sure if it's needed but I'm too tired/lazy to figure out right now)

start mozilla. See it crash.

The problem is that an assumption is made about the cache always being
available, which is wrong (GetCacheSession(...)).

I'll attach my quick hack which "fixed" this for me.

Comment 1

[Peter "jag" Annema]

Attachment: [patch] hacky fix

Comment 2

[timeless]

+    //NS_ASSERTION(gSession, "Unable to create a cache session");
doesn't make much sense, either add a line that outputs a warning or don't put 
anything back.

Comment 3

[Peter "jag" Annema]

Sorry timeless, next time I'll more explicitely say "this is _not_ supposed to
be checked in as is, it is merely an indication of what I did to work around /
fix this bug" to save you the trouble of reviewing the code :-)

Comment 4

[Stuart Parmenter]

Attachment: patch

Comment 5

[Peter "jag" Annema]

r=jag

Comment 6

[Stuart Parmenter]

Attachment: patch that works

Comment 7

[Stuart Parmenter]

this patch actually compiles and doesn't crash :-)

Comment 8

[Peter "jag" Annema]

Erh, duh. r=jag

Comment 9

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 10

[Stuart Parmenter]

fixed

Comment 11

[Terri Preston]

Verified