Closed Bug 745062 Opened 12 years ago Closed 12 years ago

memcached backend doesn't filter tabs correctly

Categories

(Cloud Services Graveyard :: Server: Sync, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: rfkelly, Unassigned)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

A simple typo/oversight in the memcached backend causes it not to apply query parameter filters like "newer" to the tabs collection.  Attached patch should be self-explanatory.

There's actually already a test for this as part of the functional suite, but `make test` doesn't run it against the memcached backend by default.  We should fix the test suite to enable this, but that's a separate bug.
Attachment #614660 - Flags: review?(telliott)
Attachment #614660 - Flags: review?(telliott) → review+
https://github.com/mozilla-services/server-syncstorage/commit/36c2dc8d77699c514fe6a44384a0feb9424a9a5d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Code verified and passed functional tests of Sync 2.0 and AITC 1.0 for a current deploy to qa1.
Status: RESOLVED → VERIFIED
OK. Will re-verify against sync 1.1.
Product: Cloud Services → Cloud Services Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: