745193 - Set MINIDUMP_SAVE_PATH environment var to a valid path for Talos runs

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement, P2)

Description

[(not currently active) Ted Mielczarek]

bug 744442 made MINIDUMP_SAVE_PATH work for Talos. I'd like to get this env var set for Talos runs as well now to help track down bug 743123.

Comment 1

[Armen [:armenzg]]

ted, what are the values for each OS?

Comment 2

[(not currently active) Ted Mielczarek]

We just need to do the exact same thing we did in bug 544062, but for the Talos runs. It just uses "%(basedir:-)s/minidumps".

Comment 3

[Chris AtLee [:catlee]]

Where does minidump live for talos runs? I can't find references to it in the logs.

Also, what will be responsible for cleaning up these dumps?

Comment 4

[(not currently active) Ted Mielczarek]

Minidumps get put in $profile/minidumps, but there's code in Talos now that if this environment variable is set, it will move them there.

In bug 544062, the minidumps got stored somewhere that someone assured me would get cleaned up as a part of the normal slave cleanup process.

Comment 5

[Mats Palmgren (inactive)]

What's the status on fixing this and bug 743123?  It's extremely important
that developers get either a stackwalk in the log, or the raw crash dump
if we're ever going to fix these intermittent crashes we have.

Comment 6

[[e-mail] (:bhearsum)]

I think this is either fixed already or not necessary now that we have blobber...

Comment 7

[(not currently active) Ted Mielczarek]

I'm not totally sure. Mihai: do you know if this got set for Talos runs? If not it should be just a matter of setting it like we do for unittests.

Comment 8

[Mihai Tabara [:mtabara]⌚️GMT]

@Ted: MINIDUMP_SAVE_PATH is also set for talos.
See http://hg.mozilla.org/build/mozharness/file/a367d867b0ef/mozharness/mozilla/testing/talos.py#l561