745329 - Pop-up blockers traps middle clicks on https://etherpad.mozilla.org

Status: RESOLVED INCOMPLETE

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[alex_mayorga]

Steps to reproduce:
Load https://etherpad.mozilla.org/testday-20120413
Middle click any of the links in "Public Pad"

Result:
Links are trapped by the pop-up blocker

Expected result:
Links open in new tabs

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

Mid-click also does not work in current release on XP SP3

Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko/20100101 Firefox/11.0

I suspect its an 'etherpad' issue, or by design.

Comment 2

[Mikel]

I can just add that in Opera and Chrome this works as it should (link opens in a new tab), and in IE it does nothing when you middle click on links.

Comment 3

[alex_mayorga]

This is still an issue on Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120601030520

A more recent MoPad that exhibits the problem https://etherpad.mozilla.org/testday-20120601

Comment 4

[Boris Zbarsky [:bzbarsky]]

Which exact links are being clicked?  It's really hard to try to reproduce this, because I see no obvious links there....

Comment 5

[Loic]

(In reply to Boris Zbarsky (:bz) from comment #4)
> Which exact links are being clicked?  It's really hard to try to reproduce
> this, because I see no obvious links there....

Open https://etherpad.mozilla.org/testday-20120601 and middle click on the 1st link on line #30.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Ah, thanks.

Is this very middle-click specific?  Option+Click on my Mac, which should be equivalent to middle-click I believe, works fine....

Comment 7

[Loic]

Yes, it's likely platform-dependent. I tested with the latest Nightly on Win 7 and the middle click has been blocked by the native popup blocker.

Comment 8

[Boris Zbarsky [:bzbarsky]]

The native popup blocker doesn't block "middle click".  It _does_ block attempts to call window.open() from inside middle click, though.  Is the page doing that (and calling preventDefault to prevent the normal Firefox UI handling of middle click)?

Comment 9

[Loic]

Yes, by middle click I mean FF prevents etherpad.mozilla.org from opening a pop-up window after middle clicking on the link.

Comment 10

[Jim Jeffery not reading bug-mail 1/2/11]

Why would you middle-click, any link on Etherpad pages automatically opens in a New Tab so there is no worry about going to link and 'leaving' the Etherpad page.

Ctrl+Click opens a New tab, not a 'window',  on Win7 x64 latest hourly m-c win32 opt build.  

Same as comment #7, I see the pop-up blocker appear in the address bar.  Just 'allow' popups and move on, I don't see this as a problem.

Mid-click in latest Chrome opens the link in a new tab.

Comment 11

[alex_mayorga]

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #10)
> Why would you middle-click, any link on Etherpad pages automatically opens
> in a New Tab so there is no worry about going to link and 'leaving' the
> Etherpad page.

"Muscle memory" I'd say, I always "click" with the scroll wheel if I want the link to open in a background tab.

This particular case is the only time I've seen this caught by the pop-up blocker IIRC.

Comment 12

[Boris Zbarsky [:bzbarsky]]

This site no longer exists... going to mark incomplete.