Closed
Bug 745498
Opened 12 years ago
Closed 12 years ago
Add testcases for DOM4 exception types
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: emk, Assigned: emk)
References
Details
Attachments
(1 file, 2 obsolete files)
257.14 KB,
patch
|
emk
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Comment on attachment 615099 [details] [diff] [review] patch Review of attachment 615099 [details] [diff] [review]: ----------------------------------------------------------------- r=me with that change. Yay! ::: content/base/test/file_bug416317.xhtml @@ +494,5 @@ > return root[select](q, resolver); > } catch(e){ > + if ( e.message.indexOf("ERR") > -1 || > + e.name == "NamespaceError" && e.code == DOMException.NAMESPACE_ERR || > + e.name == "SyntaxError" && e.code == DOMException.SYNTAX_ERR) Please don't rely on the fact that && has higher precedence than || since that's not obvious to everyone. So add some parenthesis here. @@ +548,5 @@ > try { > results = query(q, resolver); > } catch(e) { > + pass = (e.message === "bad ERROR" || > + e.name == "NamespaceError" && e.code == DOMException.NAMESPACE_ERR); Same here
Attachment #615099 -
Flags: review?(jonas) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #615099 -
Attachment is obsolete: true
Attachment #618253 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 4•12 years ago
|
||
content/test/unit/test_range.js appears to be bitrotted. Please rebase.
Keywords: checkin-needed
Assignee | ||
Comment 5•12 years ago
|
||
Conflicted with bug 702948. Rebased.
Attachment #618253 -
Attachment is obsolete: true
Attachment #618651 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bafdd54189ee
Keywords: checkin-needed
Target Milestone: --- → mozilla15
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bafdd54189ee
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•