Closed
Bug 745524
Opened 12 years ago
Closed 12 years ago
Minor code cleanup in PopupNotifications.jsm
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 14
People
(Reporter: tetsuharu, Assigned: tetsuharu)
References
Details
(Whiteboard: [doorhanger])
Attachments
(1 file, 4 obsolete files)
7.28 KB,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
Form PopupNotifications.jsm. *Define some properties which are substituted but not clearly specify. *Add curly bracket to statement. *Fill "," or ";".
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #615122 -
Flags: review?(dolske)
Assignee | ||
Updated•12 years ago
|
Whiteboard: [doorhanger]
Comment 2•12 years ago
|
||
Comment on attachment 615122 [details] [diff] [review] proposed patch I'd rather not do all the brace conversion (|if (x) y| --> |if(x) { y }|. The other parts should be fine, though I'd like to look again without the extra diffs from the bracing.
Attachment #615122 -
Flags: review?(dolske) → review-
Assignee | ||
Comment 3•12 years ago
|
||
The patch without bracing.
Attachment #615122 -
Attachment is obsolete: true
Attachment #615194 -
Flags: review?(dolske)
Assignee | ||
Comment 4•12 years ago
|
||
The patch with bracing only. I think, add bracing will be decrease bugs and developer's cobweb on debug. And also, changing parts will separate purely from add bracing in the future.
Attachment #615196 -
Flags: review?(dolske)
Assignee | ||
Comment 5•12 years ago
|
||
The patch with bracing only. I think, add bracing will be decrease bugs and developer's cobweb on debug. And also, changing parts will separate purely from add bracing in the future.
Attachment #615196 -
Attachment is obsolete: true
Attachment #615196 -
Flags: review?(dolske)
Attachment #615197 -
Flags: review?(dolske)
Updated•12 years ago
|
Summary: Form PopupNotifications.jsm → Minor code cleanup in PopupNotifications.jsm
Updated•12 years ago
|
Assignee: nobody → saneyuki.s.snyk
Comment 6•12 years ago
|
||
Comment on attachment 615194 [details] [diff] [review] patch (part1) r+, again I didn't test so assuming it works. ;)
Attachment #615194 -
Flags: review?(dolske) → review+
Comment 7•12 years ago
|
||
Comment on attachment 615197 [details] [diff] [review] patch (part2) Review of attachment 615197 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to OHZEKI Tetsuharu [:saneyuki_s] from comment #5) > The patch with bracing only. > I think, add bracing will be decrease bugs and developer's cobweb on debug. > And also, changing parts will separate purely from add bracing in the future. Style here varies across the codebase; some places do it one way, others do it the other way. I don't think there's much value in changing existing code (and, similarly, I would accept new code using either style). About the only constant is that when using if+else, when either block is braced the other block should be too. So r- on this part2. (For the record: Landing just part 1 and closing this bug is ok.)
Attachment #615197 -
Flags: review?(dolske) → review-
Assignee | ||
Comment 8•12 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #7) > Comment on attachment 615197 [details] [diff] [review] > patch (part2) > > Review of attachment 615197 [details] [diff] [review]: > ----------------------------------------------------------------- > > (In reply to OHZEKI Tetsuharu [:saneyuki_s] from comment #5) > > The patch with bracing only. > > I think, add bracing will be decrease bugs and developer's cobweb on debug. > > And also, changing parts will separate purely from add bracing in the future. > > Style here varies across the codebase; some places do it one way, others do > it the other way. I don't think there's much value in changing existing code > (and, similarly, I would accept new code using either style). About the only > constant is that when using if+else, when either block is braced the other > block should be too. > > So r- on this part2. > > (For the record: Landing just part 1 and closing this bug is ok.) I get your account. Thank you for the review. I'll make the patch for check-in.
Assignee | ||
Comment 9•12 years ago
|
||
This patch for check-in.
Attachment #615194 -
Attachment is obsolete: true
Attachment #615197 -
Attachment is obsolete: true
Attachment #615203 -
Flags: review?(dolske)
Updated•12 years ago
|
Attachment #615203 -
Flags: review?(dolske) → review+
Comment 10•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/b69c5c0bb727
Target Milestone: --- → Firefox 14
Comment 11•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b69c5c0bb727
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•