745525 - Use handleEvent in PopupNotifications

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Use handleEvent in PopupNotifications.

Comment 1

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: proposed patch

Comment 2

[Justin Dolske [:Dolske]]

This seems roughly ok from a quick skim, but what's the reason for making this change? Just code cleanup?

Comment 3

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to Justin Dolske [:Dolske] from comment #2)
> This seems roughly ok from a quick skim, but what's the reason for making
> this change? Just code cleanup?

Yes. This change purposes to clean up.
Using handleEvent can decrease the part of using Function.bind() or making functions for listener only.

Comment 4

[Justin Dolske [:Dolske]]

Comment on attachment 615123 [details] [diff] [review]
proposed patch

r+ assuming this passes tests -- I didn't test it. :)

Comment 5

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: proposed patch

Rebase on the latest mozilla-central.
I can't Mochitest on all-platform because I don't have the permission to access to try-server.
But I have tried this patch, this patch worked good.

Comment 6

[Justin Dolske [:Dolske]]

Comment on attachment 615202 [details] [diff] [review]
proposed patch

Would you like tryserver access? Looks like you've been busy with lots of Mozilla stuff, so I'd be happy to vouch for you. See http://www.mozilla.org/hacking/commit-access-policy/ and http://www.mozilla.org/hacking/committer/ -- CC me if you file a bug for access so I can vouch.

Comment 7

[Josh Matthews [:jdm]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/9a2f5f601616

Comment 8

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/9a2f5f601616